<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Verdana
}
--></style>
</head>
<body class='hmmessage'>
I know. But see here from 2001:<BR>
<BR>
<A href="http://modula3.elegosoft.com/cgi-bin/cvsweb.cgi/cm3/m3-db/stable/src/LogManager.m3.diff?r1=1.1.1.1;r2=1.1.1.2">http://modula3.elegosoft.com/cgi-bin/cvsweb.cgi/cm3/m3-db/stable/src/LogManager.m3.diff?r1=1.1.1.1;r2=1.1.1.2</A><BR><BR><BR>
Something is wierd here, I agree. I think I somehow had the 1.1.1.2 version (odd), and if you look through all the other uses of TestFile, I think it is more correct.<BR>
<BR>
It seems some of the 4.1/5.1 changes never made it from a branch to head??<BR>
<BR> - Jay<BR><BR> <BR>> From: hosking@cs.purdue.edu<BR>> Date: Fri, 15 Jan 2010 10:04:48 -0500<BR>> To: jkrell@elego.de<BR>> CC: m3commit@elegosoft.com<BR>> Subject: Re: [M3commit] CVS Update: cm3<BR>> <BR>> Here's the diff between 1.1 and 1.2, which you committed. You seem to have changed the meaning. I don't understand the change.<BR>> <BR>> *** LogManager.m3.~1.1~ Thu Jan 14 13:56:42 2010<BR>> --- LogManager.m3.~1.2~ Fri Jan 15 09:59:41 2010<BR>> ***************<BR>> *** 236,241 ****<BR>> --- 236,242 ----<BR>> <BR>> PROCEDURE EmptyLog (lm: Default; nm: Pathname.T): BOOLEAN<BR>> RAISES {OSError.E} =<BR>> + VAR log: TEXT;<BR>> BEGIN<BR>> IF NOT lm.recoverable(nm) THEN<BR>> RAISE OSError.E(<BR>> ***************<BR>> *** 243,253 ****<BR>> Atom.FromText(<BR>> "no checkpointfile for log in " & nm)));<BR>> END;<BR>> ! IF TestFile(lm.logfn(nm)) THEN<BR>> ! RETURN FS.Status(nm).size > 0<BR>> ! ELSE<BR>> ! RETURN TRUE<BR>> ! END;<BR>> END EmptyLog;<BR>> <BR>> PROCEDURE Dispose (lm: Default; nm: Pathname.T) RAISES {OSError.E} =<BR>> --- 244,251 ----<BR>> Atom.FromText(<BR>> "no checkpointfile for log in " & nm)));<BR>> END;<BR>> ! log := lm.logfn(nm);<BR>> ! RETURN (NOT TestFile(log)) OR (FS.Status(log).size = 0L);<BR>> END EmptyLog;<BR>> <BR>> PROCEDURE Dispose (lm: Default; nm: Pathname.T) RAISES {OSError.E} =<BR>> <BR>> <BR>> On 15 Jan 2010, at 13:03, Jay Krell wrote:<BR>> <BR>> > CVSROOT: /usr/cvs<BR>> > Changes by: jkrell@birch. 10/01/15 13:03:10<BR>> > <BR>> > Modified files:<BR>> > cm3/m3-db/stable/src/: LogManager.m3 <BR>> > <BR>> > Log message:<BR>> > something is broken in the history here: put my version back, there is a semantic difference as to which file path is passed to FS.Status and I didn't invent the 'obfuscated' form, though the history is indeed confusing (did somebody mention that cvs and cvsweb don't work well?)<BR>> <BR> </body>
</html>