<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
FONT-SIZE: 10pt;
FONT-FAMILY:Tahoma
}
</style>
</head>
<body class='hmmessage'>I have since made some more of the changes.<BR><BR><BR><BR>
<BLOCKQUOTE>
<HR id=EC_stopSpelling>
From: jayk123@hotmail.com<BR>To: m3devel@elegosoft.com<BR>Subject: hand.c<BR>Date: Mon, 3 Sep 2007 23:15:04 +0000<BR><BR>
<META content="Microsoft SafeHTML" name=Generator>
<STYLE>
.ExternalClass .EC_hmmessage P
{padding:0px;}
.ExternalClass EC_body.hmmessage
{font-size:10pt;font-family:Tahoma;}
</STYLE>
I'm not seeing commit mail.<BR>Maybe my fault with the hotmail?<BR> <BR>I churned it relatively a lot. It's a small file.<BR>It compiles with older Microsoft C compilers -- optionally using __int64 instead of long long. (Visual C+ 8.0 worked as it was.)<BR> I would have factored out the LL suffixes, but, really, the vast majoriy, if not all, of the L and LL suffixes were unnecessary, right?<BR> I removed most of them.<BR>It is valid C++ now -- optional prototypes.<BR>There was a race condition in initialization, fixed.<BR>gcc -Wall complained about a safe signed/unsigned compare, fixed.<BR> <BR>Not changed:<BR> all these longs should be unsigned long, right?<BR> Or at least the bits, if not the input bit indices?<BR> Negative bit indices should be either rejected or converted to 0, and then treated as unsigned from there, right?<BR> <BR> _lowbits and _highbits should be<BR> extern const ?<BR> only on x86, right? I'm still checking if they are referenced for all targets or only x86<BR> <BR> HighBits and LowBits should be, like..ok switched to<BR> #if LONG_MAX == 2147483647<BR> extern const .. hard coded 32 bit values ...<BR> #elif LONG_MAX == 9223372036854775807<BR> extern const .. hard coded 64 bit values ...<BR> #else<BR> either compute them like currently or #error<BR> #endif<BR> <BR>right?<BR> <BR>And if it is 32 bits, share the values of HighBits with _highbits, LowBits with _lowbits?<BR>They aren't /quite/ the same, but almost. _lowbits and _highbits have one extra value, the zeros at the ends I think it was.<BR> <BR> - Jay<BR><BR>
<HR>
Get news, entertainment and everything you care about at Live.com. <A href="http://www.live.com/getstarted.aspx" target=_blank>Check it out!</A> </BLOCKQUOTE><br /><hr />Kick back and relax with hot games and cool activities at the Messenger Café. <a href='http://www.cafemessenger.com?ocid=TXT_TAGLM_SeptWLtagline' target='_new'>Play now!</a></body>
</html>