<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'><div><font face="Calibri">http://modula3.elegosoft.com/cgi-bin/cvsweb.cgi/cm3/m3-sys/m3middle/src/M3CG_Rd.m3.diff?r1=1.14;r2=1.15;f=u</font></div><div><span style="font-family: Calibri; "><br></span></div><div><span style="font-family: Calibri; "><br></span></div><div><span style="font-family: Calibri; ">Tony, now I'm reviewing your changes (CVS sure doesn't make this easy!)</span></div><div><span style="font-family: Calibri; ">Apparent problem here.</span></div><div><span style="font-family: Calibri; ">Granted, I could have left a comment in the code as to what was going on.</span></div><div><span style="font-family: Calibri; ">(not that the vast bulk of m3-sys is well commented!)</span></div><div><span style="font-family: Calibri; "><br></span></div><div><br></div><div><br></div><div><span style="font-family: Calibri; ">Revision 1.15: download - view: text, markup, annotated - select for diffs</span></div><div><font face="Calibri">Tue Sep 4 16:52:46 2012 (41 hours, 23 minutes ago) by hosking</font></div><div><font face="Calibri">Branches: MAIN</font></div><div><font face="Calibri">CVS tags: HEAD</font></div><div><font face="Calibri">Diff to: previous 1.14: preferred, unified</font></div><div><font face="Calibri">Changes since revision 1.14: +2 -2 lines</font></div><div><font face="Calibri">Best to retain error checking on return values from Convert.ToInt.</font></div><div><font face="Calibri"><br></font></div><div><font face="Calibri"><br></font></div><div><span style="font-family: Calibri; ">See here:</span></div><div><font face="Calibri"><br></font></div><div><font face="Calibri">Revision 1.14: download - view: text, markup, annotated - select for diffs</font></div><div><font face="Calibri">Wed Aug 22 16:15:40 2012 (2 weeks ago) by jkrell</font></div><div><font face="Calibri">Branches: MAIN</font></div><div><font face="Calibri">Diff to: previous 1.13: preferred, unified</font></div><div><font face="Calibri">Changes since revision 1.13: +2 -2 lines</font></div><div><font face="Calibri">when printing variables and procedures:</font></div><div><font face="Calibri">e.g:</font></div><div><font face="Calibri"><span class="Apple-tab-span" style="white-space:pre"> </span>begin_procedure<span class="Apple-tab-span" style="white-space:pre"> </span> p.32</font></div><div><font face="Calibri"><span class="Apple-tab-span" style="white-space:pre"> </span>store<span class="Apple-tab-span" style="white-space:pre"> </span> v.33 0 Addr Addr</font></div><div><font face="Calibri"><br></font></div><div><font face="Calibri">instead:</font></div><div><font face="Calibri"><span class="Apple-tab-span" style="white-space:pre"> </span>begin_procedure<span class="Apple-tab-span" style="white-space:pre"> </span> p.32.Makefile__NoteSourceFile</font></div><div><font face="Calibri"><span class="Apple-tab-span" style="white-space:pre"> </span>store<span class="Apple-tab-span" style="white-space:pre"> </span> v.33.file 0 Addr Addr</font></div><div><font face="Calibri"><br></font></div><div><font face="Calibri">i.e. much more readable</font></div><div><font face="Calibri">granted, less compact, not "normalized" (redundant data)</font></div><div><font face="Calibri"><br></font></div><div><font face="Calibri">I verified that m3cgcat still roundtrips.</font></div><div><font face="Calibri"> Not that I ever tried that before, but that is what</font></div><div><font face="Calibri"> the design implied the ability to do. Not that</font></div><div><font face="Calibri"> it is likely important these days/years/decades.</font></div><div><font face="Calibri"><br></font></div><div><font face="Calibri">The delimiting "." is chosen to stop integer parsing</font></div><div><font face="Calibri">It is presumed names don't contain spaces, or whatever,</font></div><div><font face="Calibri">that M3CG_Rd is ok with this extra output from M3CG_Wr.</font></div><div><font face="Calibri">I only tried with one file.</font></div><div><font face="Calibri"><br></font></div><div><font face="Calibri">Note that I hacked M3CG_Rd__CvtInt to not complain about the extra text.</font></div><div><font face="Calibri">It might be better to have it verify it some, like that it is dot</font></div><div><font face="Calibri">followed by star or a valid pair of "__" delimited identifiers.</font></div><div style="font-family: Calibri; font-size: 12pt; "><br></div> </div></body>
</html>