<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'><div><font face="Calibri, sans-serif">Olaf, here's an easy bug to understand that you introduced.</font></div><div><font face="Calibri, sans-serif">It is a bug in the test code, not a bug otherewise.</font></div><div><font face="Calibri, sans-serif">Think about how to fix it?</font></div><div><font face="Calibri, sans-serif">I think in this case, we can just have expected-output.1, </font><span style="font-family: Calibri, sans-serif; ">expected-output.2, </span><span style="font-family: Calibri, sans-serif; ">expected-output.3, etc. as needed.</span></div><div><span style="font-family: Calibri, sans-serif; ">The "check" code can enumerate and as long as the output matches any one of the expected outputs, pass.</span></div><div><span style="font-family: Calibri, sans-serif; ">That is, even if Linux somehow accidentally outputs "dylib" or Darwin output "so", we'd claim success.</span></div><div><span style="font-family: Calibri, sans-serif; ">There are "tighter" alternatives. You could have expected-output.Linux, expected-output.Darwin, expected-output.NT, expected-output.Solaris, expected-output.FreeBSD, but many of them are identical and it is unnecessary per-target work.</span></div><div><span style="font-family: Calibri, sans-serif; ">Maybe expected-output-so and expected-output-dylib, and the checker can enumerate expected-output-*.</span></div><div><span style="font-family: Calibri, sans-serif; "><br></span></div><div><span style="font-family: Calibri, sans-serif; "><br></span></div><div><span style="font-family: Calibri, sans-serif; ">I don't think expected-output-I386_DARWIN, expected-output-I386_LINUX, etc. is the way to go, but it is an option. Too much repetition/bloat.</span></div><div><span style="font-family: Calibri, sans-serif; "><br></span></div><div><span style="font-family: Calibri, sans-serif; "><br></span></div><div><span style="font-family: Calibri, sans-serif; ">The test suite is handy btw. The C backend passes most of the tests already. :)</span></div><div><span style="font-family: Calibri, sans-serif; "><br></span></div><div><span style="font-family: Calibri, sans-serif; "><br></span></div><div><span style="font-family: Calibri, sans-serif; ">--- ../src/p2/p223/stdout.build</span><span class="Apple-tab-span" style="font-family: Calibri, sans-serif; white-space: pre; "> </span><span style="font-family: Calibri, sans-serif; ">2009-12-15 03:04:02.000000000 -0800</span></div><div><font face="Calibri, sans-serif">+++ ../src/p2/p223/I386_DARWIN/stdout.build<span class="Apple-tab-span" style="white-space:pre"> </span>2012-09-20 13:44:54.000000000 -0700</font></div><div><font face="Calibri, sans-serif">@@ -1,11 +1,13 @@</font></div><div><font face="Calibri, sans-serif"> make_dir(PKG_INSTALL & "/p223/" & TARGET)</font></div><div><font face="Calibri, sans-serif"> install_file(".M3EXPORTS", PKG_INSTALL & "/p223/" & TARGET, "0664")</font></div><div><font face="Calibri, sans-serif"> make_dir(LIB_INSTALL)</font></div><div><font face="Calibri, sans-serif">-install_file("liblib.so.5", LIB_INSTALL, "0775")</font></div><div><font face="Calibri, sans-serif">+install_file("liblib.5.2.dylib", LIB_INSTALL, "0775")</font></div><div><font face="Calibri, sans-serif"> symbolic_link_file(PKG_INSTALL & "/p223/" & TARGET & "/liblib.a", LIB_INSTALL & "/liblib.a")</font></div><div><font face="Calibri, sans-serif">-symbolic_link_file("liblib.so.5", LIB_INSTALL & "/liblib.so")</font></div><div><font face="Calibri, sans-serif">-symbolic_link_file(LIB_INSTALL & "/liblib.so.5", PKG_INSTALL & "/p223/" & TARGET & "/liblib.so")</font></div><div><font face="Calibri, sans-serif">-symbolic_link_file(LIB_INSTALL & "/liblib.so.5", PKG_INSTALL & "/p223/" & TARGET & "/liblib.so.5")</font></div><div><font face="Calibri, sans-serif">+symbolic_link_file("liblib.5.2.dylib", LIB_INSTALL & "/liblib.dylib")</font></div><div><font face="Calibri, sans-serif">+symbolic_link_file("liblib.5.2.dylib", LIB_INSTALL & "/liblib.5.dylib")</font></div><div><font face="Calibri, sans-serif">+symbolic_link_file(LIB_INSTALL & "/liblib.5.2.dylib", PKG_INSTALL & "/p223/" & TARGET & "/liblib.dylib")</font></div><div><font face="Calibri, sans-serif">+symbolic_link_file(LIB_INSTALL & "/liblib.5.2.dylib", PKG_INSTALL & "/p223/" & TARGET & "/liblib.5.dylib")</font></div><div><font face="Calibri, sans-serif">+symbolic_link_file(LIB_INSTALL & "/liblib.5.2.dylib", PKG_INSTALL & "/p223/" & TARGET & "/liblib.5.2.dylib")</font></div><div><font face="Calibri, sans-serif"> install_file("liblib.a", PKG_INSTALL & "/p223/" & TARGET, "0664")</font></div><div><font face="Calibri, sans-serif"> install_file("liblib.m3x", PKG_INSTALL & "/p223/" & TARGET, "0664")</font></div><div><font face="Calibri, sans-serif"> install_file(".M3WEB", PKG_INSTALL & "/p223/" & TARGET, "0664")</font></div><div style="font-family: Calibri, sans-serif; font-size: 12pt; "><br></div><br><br> </div></body>
</html>