[M3commit] CVS Update: cm3
Jay Krell
jkrell at elego.de
Wed Sep 26 09:36:13 CEST 2012
CVSROOT: /usr/cvs
Changes by: jkrell at birch. 12/09/26 09:36:13
Modified files:
cm3/m3-sys/cm3/src/: Makefile.m3
Log message:
cleanup: cnt: INTEGER => got_mode: BOOLEAN
It is safer, cleaner, more correct to set bool := TRUE
than to INC(int).
The integer can wraparound and become FALSE.
There is no extra value in it -- we only check for cnt > 0.
We don't need the read/modify/write of INC, just the write of assignment to FALSE
I don't know why people use this pattern, but I've seen it before.
It seems like extra work for no value.
More information about the M3commit
mailing list