[M3commit] [modula3/cm3] c00008: Fix 1st problem in cm3ide reported by Wolfgang Kel...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/modula3/cm3
  Commit: c00008869ef1c4588ce0a62b0e4b6da5171ae608
      https://github.com/modula3/cm3/commit/c00008869ef1c4588ce0a62b0e4b6da5171ae608
  Author: Rodney Bates <rodney.m.bates at acm.org>
  Date:   2016-09-29 (Thu, 29 Sep 2016)

  Changed paths:
    M m3-sys/cm3ide/src/Main.m3

  Log Message:
  -----------
  Fix 1st problem in cm3ide reported by Wolfgang Keller <9103784 at gmx.de>

This seems to have been a timing nondeterminacy between starting up of
the web server and display threads of cm3ide.  These were able to
happen concurrently, and when the display thread asks the web browser
to open a page first, there is no server to provide it, and the web
browser fails.  The failure was intermittent on my machine.

Surely this must have worked at one time.  I have never used or gotten
inside cm3ide before, so this is a bit speculative, but I am guessing
the change from user threads to pthreads may have altered which one
usually wins the race, making the latent bug show up.


  Commit: bcf4abe5bdd3af5bea372bd7fdf51dbf60619a86
      https://github.com/modula3/cm3/commit/bcf4abe5bdd3af5bea372bd7fdf51dbf60619a86
  Author: Rodney Bates <rodney.m.bates at acm.org>
  Date:   2016-09-29 (Thu, 29 Sep 2016)

  Changed paths:
    M m3-sys/cm3ide/src/misc/Display.m3

  Log Message:
  -----------
  Improve some misleading log messages in cm3ide, regarding startup.

The messages could be misleading in some cases.  The make claims about
what "start_browser" returned in cases when it didn't even return at
all, or even get called.

The shutdown message could still be improved by giving a higher-level
explanation of what "start_browser" returned (a user can hardly be
expected even to know what "start_browser" is).  But the comments on
what its return value really means are confusing.


Compare: https://github.com/modula3/cm3/compare/d31f6ca184c6...bcf4abe5bdd3