[M3devel] FW: hand.c

[Ronny Forberger]

The mailling list software had unfortunately held back these mails, as  
they could not be processed for some reason like not being able to  
contact the spam analyzer when sometimes that one gets restarted. It  
did not make any retry, so I had to send them out manually. :(

Ronny

--
Message from: Tony Hosking <hosking at cs.purdue.edu>
Date: Di 11 Mär 2008 00:31:14 CET
Subject: Re: [M3devel] FW: hand.c


> OK, weird.  Now I'm getting e-mail from 6 months ago.  Talk about deja
> vu.  Any ideas what's going on?
>
> Antony Hosking | Associate Professor | Computer Science | Purdue  University
> 305 N. University Street | West Lafayette | IN 47907 | USA
> Office +1 765 494 6001 | Mobile +1 765 427 5484
>
>
>
> On Sep 15, 2007, at 10:39 PM, Jay wrote:
>
>> I have since made some more of the changes.
>>
>>
>>
>> From: jayk123 at hotmail.com
>> To: m3devel at elegosoft.com
>> Subject: hand.c
>> Date: Mon, 3 Sep 2007 23:15:04 +0000
>>
>> I'm not seeing commit mail.
>> Maybe my fault with the hotmail?
>>
>> I churned it relatively a lot. It's a small file.
>> It compiles with older Microsoft C compilers -- optionally using    
>> __int64 instead of long long. (Visual C+ 8.0 worked as it was.)
>>  I would have factored out the LL suffixes, but, really, the vast    
>> majoriy, if not all, of the L and LL suffixes were unnecessary,   
>> right?
>>  I removed most of them.
>> It is valid C++ now -- optional prototypes.
>> There was a race condition in initialization, fixed.
>> gcc -Wall complained about a safe signed/unsigned compare, fixed.
>>
>> Not changed:
>>  all these longs should be unsigned long, right?
>>  Or at least the bits, if not the input bit indices?
>>  Negative bit indices should be either rejected or converted to 0,   
>>  and then treated as unsigned from there, right?
>>
>>  _lowbits and _highbits should be
>>       extern const ?
>>       only on x86, right? I'm still checking if they are referenced  
>>   for all targets or only x86
>>
>> HighBits and LowBits should be, like..ok switched to
>>  #if LONG_MAX == 2147483647
>>   extern const .. hard coded 32 bit values ...
>>  #elif LONG_MAX == 9223372036854775807
>>   extern const .. hard coded 64 bit values ...
>>  #else
>>   either compute them like currently or #error
>> #endif
>>
>> right?
>>
>> And if it is 32 bits, share the values of HighBits with _highbits,   
>>  LowBits with _lowbits?
>> They aren't /quite/ the same, but almost. _lowbits and _highbits    
>> have one extra value, the zeros at the ends I think it was.
>>
>> - Jay
>>
>> Get news, entertainment and everything you care about at Live.com.   
>>  Check it out!
>>
>> Kick back and relax with hot games and cool activities at the    
>> Messenger Café. Play now!



-- 

Ronny Forberger
Systemadministration & IT-Support

elego Software Solutions GmbH
Gustav-Meyer-Allee 25
Gebäude 12, Raum 227
D-13355 Berlin

Tel. +49 30 23 45 86 96      ronny.forberger at elegosoft.com
Fax  +49 30 23 45 86 95      http://www.elegosoft.com

Geschäftsführer: Olaf Wagner, Sitz Berlin
Amtsgericht Berlin-Charlottenburg, HRB 77719, USt-IdNr: DE163214194