[M3devel] FW: Win32/ScrollerVBTClass.m3

[Jay K]

Yes it was crashing on Windows.
It wasn't really "Windows-specific", it was specifically in the code Randy added.
The two files are largely the same and they are both portable.
It's just a matter of what pictures get drawn using the same underlying Trestle graphics functions.
That is, the code is portable either way, it's just a behaviorial/visual decision that is made.
You know, you could perfectly well allow:

  mentor -gui-style=windows 
  mentor -gui-style=trestle 

You know, this isn't low level code, it is "middle".

 - Jay


From: hosking at cs.purdue.edu
Date: Mon, 14 Dec 2009 10:10:37 -0500
To: jay.krell at cornell.edu
CC: m3devel at elegosoft.com
Subject: Re: [M3devel] FW: Win32/ScrollerVBTClass.m3



Do you mean mentor crashing on Windows?  I would not like us to introduce new bugs to X11-based Trestle by merging Windows with X11 Trestle.


On 13 Dec 2009, at 20:43, Jay K wrote:Randy's changes make the Windows GUI look more like
Windows. My changes make mentor not crash starting
up just by checking for NIL and taking a lock.
I don't understand Trestle's locking and the comments
explaining it were too long for me to understand,
so I'm just guessing.
 
Given how ugly and non-uniform X Windows GUIs tend to be,
Trestle being a good example -- it has its own
unique ugly look, changing is not a bad idea,
but not done here.
 
- Jay

 
From: hosking at cs.purdue.edu
Date: Sun, 13 Dec 2009 13:30:18 -0500
To: rcoleburn at scires.com
CC: m3devel at elegosoft.com; jay.krell at cornell.edu
Subject: Re: [M3devel] FW: Win32/ScrollerVBTClass.m3

Is that what these changes do?  Make POSIX GUI like Windows.  Let's please not do that gratuitously.

On 13 Dec 2009, at 00:02, Randy Coleburn wrote:Jay: Back in 2008 when I made these changes I did go to the current source tree and factor all this work into the then current tree.  It was not a file replace situation, but rather very careful work trying to merge the changes back into the current tree.  The POSIX implementation did not change, because the modifications were intended for Windows only.  I think it would be wrong to try and make the GUI on Unix look like Windows. Regards,Randy

>>> Jay K <jay.krell at cornell.edu> 12/12/2009 10:41 PM >>>
2008-05-27 02:29  rcoleburn

  * m3-ui/vbtkit/src/: lego/m3makefile, vbtkitresources/ScrollBg,
    vbtkitresources/close.ppm, vbtkitresources/down.ppm,
    vbtkitresources/grow.ppm, vbtkitresources/left.ppm,
    vbtkitresources/m3makefile, vbtkitresources/right.ppm,
    vbtkitresources/up.ppm, lego/POSIX/ScrollerVBTClass.m3,
    lego/POSIX/ZChassisVBT.m3, lego/POSIX/m3makefile,
    vbtkitutils/m3makefile, lego/WIN32/ScrollerVBTClass.m3,
    lego/WIN32/ZChassisVBT.m3, lego/WIN32/m3makefile,
    vbtkitutils/POSIX/VBTKitEnv.i3, vbtkitutils/POSIX/m3makefile,
    vbtkitutils/WIN32/VBTKitEnv.i3, vbtkitutils/WIN32/m3makefile:

  Incorporate changes made to vbtkit by Critical Mass circa September 1997 that make the GUI appearance more like that of Windows.  The m3makefiles have been adjusted so that these changes affect only Windows (WIN32) platforms.  These changes were part of work sponsored by Randy Coleburn at Scientific Research Corporation (SRC).  The main files affected are VBTKitEnv.i3, ScrollerVBTClass.m3, and ZChassisVBT.m3, plus some new resource files have been added for WIN32 only.


Randy, are files from 1997 really correct to incorporate into the tree 11 years later? Or maybe they are rather out of date?
Can the work be redone against the 2008 versions? And factor out the common parts?
 
I guess I should go and diff these against the 3.6 or 4.1 versions?
And then apply those diffs to the Posix file to get the Win32 version?
(Or again, try to share what is the same?)
 
 
 - Jay
 
> Date: Sun, 13 Dec 2009 04:37:34 +0000
> To: m3commit at elegosoft.com
> From: jkrell at elego.de
> Subject: [M3commit] CVS Update: cm3
> 
> CVSROOT: /usr/cvs
> Changes by: jkrell at birch. 09/12/13 04:37:34
> 
> Modified files:
> cm3/m3-ui/vbtkit/src/lego/: Tag: release_branch_cm3_5_8 
> m3makefile 
> cm3/m3-ui/vbtkit/src/lego/WIN32/: Tag: release_branch_cm3_5_8 
> ScrollerVBTClass.m3 
> 
> Log message:
> I forgot to mention: I'm really just guessing here. It seems to work.
> 


 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://m3lists.elegosoft.com/pipermail/m3devel/attachments/20091214/2cf19a4f/attachment-0002.html>