[M3devel] FW: hand.c

Jay jay.krell at cornell.edu
Sun Sep 16 04:40:08 CEST 2007

I have since made some more of the changes.

From: jayk123 at hotmail.comTo: m3devel at elegosoft.comSubject: hand.cDate: Mon, 3 Sep 2007 23:15:04 +0000

I'm not seeing commit mail.Maybe my fault with the hotmail? I churned it relatively a lot. It's a small file.It compiles with older Microsoft C compilers -- optionally using __int64 instead of long long. (Visual C+ 8.0 worked as it was.)  I would have factored out the LL suffixes, but, really, the vast majoriy, if not all, of the L and LL suffixes were unnecessary, right?  I removed most of them.It is valid C++ now -- optional prototypes.There was a race condition in initialization, fixed.gcc -Wall complained about a safe signed/unsigned compare, fixed. Not changed:  all these longs should be unsigned long, right?  Or at least the bits, if not the input bit indices?  Negative bit indices should be either rejected or converted to 0, and then treated as unsigned from there, right?   _lowbits and _highbits should be       extern const ?       only on x86, right? I'm still checking if they are referenced for all targets or only x86  HighBits and LowBits should be, like..ok switched to  #if LONG_MAX == 2147483647   extern const .. hard coded 32 bit values ...  #elif LONG_MAX == 9223372036854775807   extern const .. hard coded 64 bit values ...  #else   either compute them like currently or #error #endif right? And if it is 32 bits, share the values of HighBits with _highbits, LowBits with _lowbits?They aren't /quite/ the same, but almost. _lowbits and _highbits have one extra value, the zeros at the ends I think it was.  - Jay

Get news, entertainment and everything you care about at Live.com. Check it out! 
Kick back and relax with hot games and cool activities at the Messenger Café.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://m3lists.elegosoft.com/pipermail/m3devel/attachments/20070916/eee66568/attachment-0001.html>

More information about the M3devel mailing list